Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace typing.AnyStr with Union[str, bytes] #978

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Replace typing.AnyStr with Union[str, bytes] #978

merged 1 commit into from
Jul 24, 2023

Conversation

sobolevn
Copy link
Contributor

Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way is to use Union here :)

@sobolevn
Replace typing.AnyStr with Union[str, bytes]
56409e7 
Hi! While working on python/mypy#15732 our tools detected a misuse of `AnyStr` TypeVar (which is quite common). The proper way is to use `Union` here :)
benhoyt
benhoyt approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@benhoyt benhoyt merged commit 2c82af3 into canonical:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @benhoyt